One plan fails with an error. Simple statement change produces a plan that doesn't

(database backup link removed)

Msg 515, Level 16, State 2, Procedure spGetFRSubRouteNamesForDate, Line 122
Cannot insert the value NULL into column 'DefinitionEndDateTime', table 'tempdb.dbo.#sr_start_stops_____________________________________________________________________________________________________00000000005C'; column does not allow nulls. UPDATE fails.

i have forced a parallel and non-parallel version of the plans and that doesn't change things. The broken one is always broken and the fixed one is always fixed. The actual parallel plan is different from the estimated plan for the changed SQL. I can't get the actual plan for the broken one since it isn't returned when a query errors.

OPTION (RECOMPILE, QUERYTRACEON 8649)
OPTION (MAXDOP 1)

Check the part of the plan that updates #sr_start_stops.

The difference is the following part of the predicate on the update of DefinitionEndDateTime. If i comment this line out, the same statement completes without error.

AND tp.effectivestartdate >= DATEADD(day, -1, @crediteddate)

    UPDATE #sr_start_stops SET  DefinitionStartDateTime = CASE WHEN (
        SELECT DATEADD(SECOND, MIN(te.DefinitionTripStopTimeSeconds), #sr_start_stops.CalendarDate)
        FROM dbo.t_FRTripsPropertiesFRRouteStopExceptions te
        INNER JOIN dbo.t_FRTripsPropertiesFRRouteStop ts ON te.FRTripsPropertiesFRRouteStopID = ts.FRTripsPropertiesFRRouteStopID
        INNER JOIN dbo.t_FRTripsProperties tp ON tp.FRTripsPropertiesID = ts.FRTripsPropertiesID
        INNER JOIN dbo.t_FRTrips t ON t.FRTripsID = tp.FRTripsID
        WHERE te.ExceptionDate = #sr_start_stops.CalendarDate AND t.FRSubrouteID = #sr_start_stops.FRSubRouteID
            AND te.ExceptionDate BETWEEN DATEADD(day, -1, @CreditedDate) AND DATEADD(day, 1, @CreditedDate)
        ) < #sr_start_stops.DefinitionStartDateTime THEN 
            (
                SELECT DATEADD(SECOND, MIN(te.DefinitionTripStopTimeSeconds), #sr_start_stops.CalendarDate)
                FROM dbo.t_FRTripsPropertiesFRRouteStopExceptions te
                INNER JOIN dbo.t_FRTripsPropertiesFRRouteStop ts ON te.FRTripsPropertiesFRRouteStopID = ts.FRTripsPropertiesFRRouteStopID
                INNER JOIN dbo.t_FRTripsProperties tp ON tp.FRTripsPropertiesID = ts.FRTripsPropertiesID
                INNER JOIN dbo.t_FRTrips t ON t.FRTripsID = tp.FRTripsID
                WHERE te.ExceptionDate = #sr_start_stops.CalendarDate AND t.FRSubrouteID = #sr_start_stops.FRSubRouteID
                    AND te.ExceptionDate BETWEEN DATEADD(day, -1, @CreditedDate) AND DATEADD(day, 1, @CreditedDate)
            )
        ELSE #sr_start_stops.DefinitionStartDateTime
        END
    , DefinitionEndDateTime = CASE WHEN (
        SELECT DATEADD(SECOND, MAX(te.DefinitionTripStopTimeSeconds), #sr_start_stops.CalendarDate)
        FROM dbo.t_FRTripsPropertiesFRRouteStopExceptions te
        INNER JOIN dbo.t_FRTripsPropertiesFRRouteStop ts ON te.FRTripsPropertiesFRRouteStopID = ts.FRTripsPropertiesFRRouteStopID
        INNER JOIN dbo.t_FRTripsProperties tp ON tp.FRTripsPropertiesID = ts.FRTripsPropertiesID
        INNER JOIN dbo.t_FRTrips t ON t.FRTripsID = tp.FRTripsID
        WHERE te.ExceptionDate = #sr_start_stops.CalendarDate AND t.FRSubrouteID = #sr_start_stops.FRSubRouteID
            AND te.ExceptionDate BETWEEN DATEADD(day, -1, @CreditedDate) AND DATEADD(day, 1, @CreditedDate)
        ) > #sr_start_stops.DefinitionEndDateTime THEN 
            ( 
                SELECT DATEADD(SECOND, MAX(te.DefinitionTripStopTimeSeconds), #sr_start_stops.CalendarDate)
                FROM dbo.t_FRTripsPropertiesFRRouteStopExceptions te
                INNER JOIN dbo.t_FRTripsPropertiesFRRouteStop ts ON te.FRTripsPropertiesFRRouteStopID = ts.FRTripsPropertiesFRRouteStopID
                INNER JOIN dbo.t_FRTripsProperties tp ON tp.FRTripsPropertiesID = ts.FRTripsPropertiesID
                                        --if i comment out this line, the error will not happen.
                    AND tp.effectivestartdate >= DATEADD(day, -1, @crediteddate)
                INNER JOIN dbo.t_FRTrips t ON t.FRTripsID = tp.FRTripsID
                WHERE te.ExceptionDate = #sr_start_stops.CalendarDate AND t.FRSubrouteID = #sr_start_stops.FRSubRouteID
                    AND te.ExceptionDate BETWEEN DATEADD(day, -1, @CreditedDate) AND DATEADD(day, 1, @CreditedDate)
            )
        ELSE #sr_start_stops.DefinitionEndDateTime
        END